fix: ensure subgraphNFT handles metadata with leading zeros correctly #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #576 Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
tmigone
force-pushed
the
tmigone/fix-nft-tokenuri
branch
from
5e1db55
to
ff7880e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 35 35
Lines 1747 1747
Branches 290 290
=======================================
Hits 1581 1581
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Since we won't be able to deploy this fix, should we close this and leave the issue open as a known bug? (We can reopen if we ever get a chance to deploy a new SubgraphNFT for whatever reason) |
|
^ closing based on the rationale above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The tokenURI being reported by SubgraphNFT contract using the
tokenURIfunction is incorrect when the subgraph metadata hash contains leading zeroes. #576 describes the problem in detail.Changes
0x00....Closes: #576
Signed-off-by: Tomás Migone tomas@edgeandnode.com